Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup vtk read-in #361

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

landinjm
Copy link
Contributor

@landinjm landinjm commented Dec 17, 2024

Description

Cleaning up the vtk file read in and adding unit tests. In the future, we should rewrite the entire section of the code to avoid using IntegrationsTools.

Removing pFunction feature as it is rarely used and unwieldy to use. Instead we, can demonstrate how to add helper functions to customPDE.h that may reduce the bulkiness of equations.cc for complicated physics.

If we want to parallelize the read-in it becomes rather difficult. Essentially what we're doing is reading in the points and values and interpolating onto the some dealii:VectorTools::interpolate the same way we do for the initial conditions. This becomes challenging in parallel because the partitioning of vector we're interpolating onto may be different than whatever scheme we use.

Closes #124

Checklist

Miscellaneous items that may need to be done when making a PR:

  • Documentation related to this PR is up to date (Doxygen format)
  • Unit test(s)
  • Code is properly formatted
  • Application update script is up to date
  • PR labels are applied
  • Issues are linked

@landinjm landinjm changed the base branch from master to devel December 17, 2024 15:49
@landinjm landinjm force-pushed the optimize_vtk_readin branch from d7ab9fd to bb5ac93 Compare December 20, 2024 02:48
@landinjm landinjm force-pushed the optimize_vtk_readin branch 3 times, most recently from c31480c to 3bc64e7 Compare January 3, 2025 16:56
@landinjm landinjm changed the title Optimize vtk read-in Cleanup vtk read-in Jan 3, 2025
@landinjm landinjm force-pushed the optimize_vtk_readin branch from 3bc64e7 to 2ceb6b9 Compare January 3, 2025 21:07
@landinjm landinjm marked this pull request as ready for review January 3, 2025 21:28
@landinjm landinjm merged commit 64e7102 into prisms-center:devel Jan 3, 2025
3 of 5 checks passed
@landinjm landinjm deleted the optimize_vtk_readin branch January 3, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate error if the vtk file with the initial conditions isn't found
1 participant