Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaning up the vtk file read in and adding unit tests. In the future, we should rewrite the entire section of the code to avoid using IntegrationsTools.
Removing pFunction feature as it is rarely used and unwieldy to use. Instead we, can demonstrate how to add helper functions to
customPDE.h
that may reduce the bulkiness ofequations.cc
for complicated physics.If we want to parallelize the read-in it becomes rather difficult. Essentially what we're doing is reading in the points and values and interpolating onto the some
dealii:VectorTools::interpolate
the same way we do for the initial conditions. This becomes challenging in parallel because the partitioning of vector we're interpolating onto may be different than whatever scheme we use.Closes #124
Checklist
Miscellaneous items that may need to be done when making a PR: